Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix widget manifest localization #254

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Fix widget manifest localization #254

merged 2 commits into from
Aug 1, 2024

Conversation

dkbennett
Copy link
Member

@dkbennett dkbennett commented Aug 1, 2024 •
edited by krschau
Loading

Summary of the pull request

Widgets were not properly localized in the manifest. This fixes that.

References and relevant issues

Detailed description of the pull request / Additional comments

  • Added strings for widget display name, description, and alternate screenshot text.

Validation steps performed

  • Built and verified new localized strings are properly showing up in the widget list and the widgets.

PR checklist

@dkbennett dkbennett added the Needs-Second Pull request that needs another approval label Aug 1, 2024
@dkbennett dkbennett merged commit 076266e into main Aug 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krschau krschau krschau approved these changes

@guimafelipe guimafelipe guimafelipe approved these changes

@EricJohnson327 EricJohnson327 Awaiting requested review from EricJohnson327

@lauren-ciha lauren-ciha Awaiting requested review from lauren-ciha

Assignees
No one assigned
Labels
Needs-Second Pull request that needs another approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display names in the widgets should be localized
3 participants
@dkbennett @guimafelipe @krschau